Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration flow (2) #75

Merged
merged 7 commits into from
May 28, 2024
Merged

Fix registration flow (2) #75

merged 7 commits into from
May 28, 2024

Conversation

JohannesSetiawan
Copy link
Contributor

@JohannesSetiawan JohannesSetiawan commented May 28, 2024

What fixed:
-) Restrict so that only verified user can logged in.
-) Fix so system won't sent another email when there's still active token.
-) Changes token time limit to 25 minutes.
-) Make sure that every token can only be used once (delete the token every time user use it to verify their email or recover password).

Copy link
Contributor

@swastikanata swastikanata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@catherineeangel catherineeangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Copy link
Contributor

@nataniadeandra nataniadeandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@JohannesSetiawan JohannesSetiawan merged commit 4144166 into staging May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants